executor: do output area cleanup before each execution #6255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to do it after query completion, but that leaves some window open for a completely broken executor fork to mess with the data. At the same time, executor expects the area to be completely clean when it starts.
a-nogikh
force-pushed
the
features/move-cleanup
branch
from
89eb419 to
3b07dad
Compare
dvyukov
approved these changes
Aug 5, 2025
Collaborator
Author
So far I couldn't reproduce it locally. Devlink should indeed be unavailable on a test os: syzkaller/executor/common_test.h Lines 145 to 150 in 9e53e3a UPD: it reproduces, but very rarely. |
Collaborator
Author
|
If we do not clear output data at the end of It happens rarely because, for that, the proc that gets the devlink check request must happen to have already executed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to do it after query completion, but that leaves some window open for a completely broken executor fork to mess with the data. At the same time, executor expects the area to be completely clean when it starts.